Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: first instead of get(0) #136

Merged
merged 1 commit into from
Jan 23, 2024
Merged

chore: first instead of get(0) #136

merged 1 commit into from
Jan 23, 2024

Conversation

patriknw
Copy link
Member

@patriknw
Copy link
Member Author

For the record, I'm not sure why this started failing in CI without noticing before.

@patriknw patriknw merged commit 905ff52 into main Jan 23, 2024
1 check passed
@patriknw patriknw deleted the wip-first-patriknw branch January 23, 2024 07:46
@huntc
Copy link
Contributor

huntc commented Jan 23, 2024

For the record, I'm not sure why this started failing in CI without noticing before.

Possibly because the compiler and toolchain updated? CI will always (rightfully) take the latest. Clippy is part of the toolchain and has new complaints from time to time. Always valid ones! :-)

@patriknw
Copy link
Member Author

Thanks. That's fine for ci validations, but we should change that for releases. Created issue #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntc huntc huntc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patriknw @huntc