Parameterize package name #17
Conversation
| @@ -26,16 +26,6 @@ Once inside the project folder, run the application with: | |||
| sbt run | |||
| ``` | |||
|
|
|||
| This template also provides build descriptors for maven and gradle. You can use any of the following commands to run | |||
| @@ -1,2 +0,0 @@ | |||
| name=akka-quickstart-scala | |||
There was a problem hiding this comment.
Are we sure this is unused? The text is suspiciously the same as on https://developer.lightbend.com/start/?group=akka
There was a problem hiding this comment.
Are we sure this is unused?
I am not so sure, but I didn't find the same file at https://github.com/akka/akka-http-quickstart-scala.g8 and https://github.com/akka/akka-http-quickstart-java.g8. I also found this default.properties and src/main/g8/default.properties shared almost the same property values. I think I can restore since there are considerations.
BTW, I noticed the link icon of github of https://developer.lightbend.com/start/?group=akka&project=akka-http-quickstart-java and https://developer.lightbend.com/start/?group=akka&project=akka-http-quickstart-scala are both linking to 10.0.x branch.
|
|
||
| lazy val akkaVersion = "2.5.12" | ||
| lazy val akkaVersion = "$akka_version$" |
| @@ -50,7 +50,7 @@ class Printer extends Actor with ActorLogging { | |||
|
|
|||
| def receive = { | |||
| case Greeting(greeting) => | |||
| log.info(s"Greeting received (from ${sender()}): $greeting") | |||
| log.info("Greeting received (from " + sender() + "): " + greeting) | |||
There was a problem hiding this comment.
This is a bit of a shame, wouldn't there be some other way to get rid of the Fix mismatched input '$' expecting LPAREN` warning?
There was a problem hiding this comment.
I know we can use backslash \ to handle this,
log.info(s"Greeting received (from \${sender()}): \$greeting")but paradox didn't handle this. It will appear those escape characters at Lightbend Tech Hub. That's why I chose this way. If there is another way to handle this, please let me know. Thanks! :)
There was a problem hiding this comment.
Ah, so it's an interaction between paradox and g8: since we removed verbatim = *.scala (to make the variable substitution for the package name work) it now also tries to interpret the $ signs in the rest of the code, but paradox isn't prepared for that. This is fine for now then.
There was a problem hiding this comment.
(added #20 so we can revisit this later)
# Conflicts: # src/main/g8/src/test/scala/$package$/AkkaQuickstartSpec.scala
|
Thanks again, great improvement! |
No description provided.