Add support for optional snapshots #7444
Merged
+90
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much @chrisjhoare - looks like there's just a markdown linting grumble but otherwise CI/CD seems happy. We'll review this shortly! |
chrisjhoare
force-pushed
the
optional-snapshots
branch
from
2648d08 to
4da3bce
Compare
Aaronontheweb
approved these changes
Jan 8, 2025
| Enable this feature by setting `snapshot-is-optional = true` in the snapshot store configuration. | ||
|
|
||
| > [!WARNING] | ||
| >Don't set `snapshot-is-optional = true` if events have been deleted because that would result in wrong recovered state if snapshot load fails. |
| var lpref = Sys.ActorOf(Props.Create(() => new SnapshotFailureRobustnessSpec.LoadSnapshotTestActor(Name, TestActor))); | ||
| ExpectMsg<Error>(m => m.Message.ToString().StartsWith("Error loading snapshot")); | ||
| ExpectMsg("boom-1"); | ||
| ExpectMsg<RecoveryCompleted>(); |
| @@ -61,7 +62,9 @@ private EventsourcedState RecoveryStarted(long maxReplays) | |||
| // protect against snapshot stalling forever because journal overloaded and such | |||
| var timeout = Extension.JournalConfigFor(JournalPluginId).GetTimeSpan("recovery-event-timeout", null, false); | |||
| var timeoutCancelable = Context.System.Scheduler.ScheduleTellOnceCancelable(timeout, Self, new RecoveryTick(true), Self); | |||
|
|
|||
|
|
|||
| var snapshotIsOptional = Extension.SnapshotStoreConfigFor(SnapshotPluginId).GetBoolean("snapshot-is-optional", false); | |||
| { | ||
| OnRecoveryFailure(failed.Cause); | ||
| Log.Info("Snapshot load error for persistenceId [{0}]. Replaying all events since snapshot-is-optional=true", PersistenceId); |
There was a problem hiding this comment.
LGTM - might consider making this a WARNING but I think it's fine as-is for now
| # recover by replaying all events. | ||
| # Don't set to true if events are deleted because that would | ||
| # result in wrong recovered state if snapshot load fails. | ||
| snapshot-is-optional = false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation for allowing persistence snapshots to be optional when failing (issue #7382)
Changes
Setting snapshot-is-optional = true in the snapshot store configuration will allow Actors to continue if there is a failure loading the snapshot (https://doc.akka.io/libraries/akka-core/current//typed/persistence-snapshot.html#optional-snapshots)