Allow setting game directory from CLI; add -v flag #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the directory the binary is in as the default path, so you can use "./games/fallout/fallout-ce" without having to cd to that directory. - Also allow setting the game directory from argv. - Add -v option for verbose information; this was protected by a _DEBUG preprocessor flag, and not having to recompile is helpful. - Output GNWSystemError() to stderr as well. For whatever reason I don't get any popup window (not sure why), so the game would simply exit without any information. It doesn't hurt to print it anyway. - Add -h flag to document all of this. Note: I only tested this on my Linux system, as that's the only machine I have access to. In particular, I'm not entirely sure if my usage of PathRemoveFileSpecA() is correct, but I have no way to test it. Also clarify which values are read from f1_res.ini, as per my reading of src/plib/gnw/svga.cc (Fixes alexbatalov#84).
|
What about reading by default the assets in some standard path like ~/.local/share/fallout1-ce ? This would make packaging easier. I would also keep trying to read assets from the current directory as a last resort, it might be useful to some people. So it would try these paths in order:
|
|
I feel the order should be a little different but I like the idea.
Reasoning is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the directory the binary is in as the default path, so you can use "./games/fallout/fallout-ce" without having to cd to that directory.
Also allow setting the game directory from argv.
Add -v option for verbose information; this was protected by a _DEBUG preprocessor flag, and not having to recompile is helpful.
Output GNWSystemError() to stderr as well. For whatever reason I don't get any popup window (not sure why), so the game would simply exit without any information. It doesn't hurt to print it anyway.
Add -h flag to document all of this.
Note: I only tested this on my Linux system, as that's the only machine I have access to. In particular, I'm not entirely sure if my usage of PathRemoveFileSpecA() is correct, but I have no way to test it.