Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimport: clearing objects in the initial index if the temporary index has zero objects #186

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Reimport: clearing objects in the initial index if the temporary index has zero objects #186

wants to merge 9 commits into from

Conversation

borealsmith
Copy link

No description provided.

@borealsmith borealsmith mentioned this pull request Jun 6, 2019
Open
nunomaduro
nunomaduro suggested changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chloelbn will jump on this.

src/Console/Commands/ReImportCommand.php Outdated Show resolved Hide resolved
@borealsmith borealsmith marked this pull request as ready for review July 9, 2019 17:47
@nunomaduro
Copy link
Contributor

@chloelbn Can you review this one?

chloelbn
chloelbn previously approved these changes Jul 11, 2019
View reviewed changes
@chloelbn chloelbn self-requested a review July 11, 2019 08:38
@chloelbn
Copy link
Contributor

Hello @borealsmith,

Thanks for your PR! I’ve reviewed and the code seems fine, great work! Would you mind adding some tests along your feature, to ensure everything is working as intended? You can take as an example the test for the Reimport Command (https://github.com/algolia/scout-extended/blob/master/tests/Features/ReimportCommandTest.php) and add in this file a test case with 0 object to import.

@borealsmith
Copy link
Author

Hi @chloelbn,

Thank you very much for the review and feedback. Of course, no problem, my pleasure to add the test case you mention.

Best Regards,

@nunomaduro nunomaduro assigned borealsmith and unassigned chloelbn Aug 26, 2019
@borealsmith
Copy link
Author

Hi, @nunomaduro @chloelbn
Sorry for the late feedback. I'll try to find some time and write the test sometime next week.

@borealsmith
Copy link
Author

Hi,
I finally managed to add the test case for ReimportCommand in case of an empty reimport.
Best Regards,

@emanueljacob
Copy link

can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro requested changes

@chloelbn chloelbn Awaiting requested review from chloelbn

At least 1 approving review is required to merge this pull request.

Assignees

@borealsmith borealsmith

Labels
waiting for feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@borealsmith @nunomaduro @chloelbn @emanueljacob @DevinCodes