refactor(interactive): Upgrade arrow to 15.0.2 #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighingnow
previously approved these changes
Jun 7, 2024
zhanglei1949
commented
Jun 7, 2024
flex/cmake/FindArrow.cmake
Outdated
There was a problem hiding this comment.
FindArrow.cmake appears incompatible with newer versions of Arrow. Simply using find_package(arrow) appears to work. Thanks @sighingnow
zhanglei1949
commented
Jun 7, 2024
| @@ -121,12 +121,20 @@ find_package(Boost REQUIRED COMPONENTS system filesystem | |||
| context program_options regex thread date_time) | |||
| add_definitions("-DBOOST_BIND_GLOBAL_PLACEHOLDERS") | |||
|
|
|||
| #find hiactor---------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Move the import of Hiactor from bin/CMakeLists.txt to CMakeLists.txt. Otherwise cmake .. -DBUILD_HQPS=OFF will fail. Will investigate this issue later: #3903
liulx20
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_package(Hiactor) in root cmake will resolve a cmake problem, more infomation is described in #3891. Will be investigated later.