-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(interactive): Align Data Type in GIE Physical Pb with Flex #4367
base: main
Are you sure you want to change the base?
Conversation
Please check the preview of the documentation changes at |
Committed-by: xiaolei.zl from Dev container
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
@longbinlai @shirly121 We need to make sure the cypher procedure is still callable with the changes in this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4367 +/- ##
=======================================
Coverage ? 58.78%
=======================================
Files ? 12
Lines ? 592
Branches ? 0
=======================================
Hits ? 348
Misses ? 244
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
What do these changes do?
a. Groot: defined in proto
b. Flex: defined in proto
c. Calcite, defined in java
The Calcite type system serves as the foundation for type inference in the compiler. Consequently, any other type system (e.g., Groot or Flex) must be convertible to Calcite.
The IrDataTypeConvertor plays a key role in this process. It defines the bidirectional type conversions between Calcite and the other two type systems.
Related issue number
Fixes #4362