Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: thread command add option for hide internal threads #2783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: thread command add option for hide internal threads #2783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion core/src/main/java/com/taobao/arthas/core/command/monitor200/ThreadCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ public class ThreadCommand extends AnnotatedCommand {
}
}

private boolean hideInternalThreads;

@Option(longName = "hide-internal", shortName = "hi", flag = true)
@Description("Hide internal threads")
public void setHideInternalThreads(final boolean hideInternalThreads) {
this.hideInternalThreads = hideInternalThreads;
}

@Argument(index = 0, required = false, argName = "id")
@Description("Show thread stack")
public void setId(long id) {
Expand Down Expand Up @@ -143,7 +151,7 @@ private ExitStatus processAllThreads(CommandProcess process) {
stateCountMap.put(threadState, count + 1);
}

boolean includeInternalThreads = true;
boolean includeInternalThreads = !this.hideInternalThreads;
Collection<ThreadVO> resultThreads = new ArrayList<ThreadVO>();
if (!StringUtils.isEmpty(this.state)) {
this.state = this.state.toUpperCase();
Expand Down