fix: expiration time did not respect environment variable #915 #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roiocam
changed the title
Roiocam
changed the title
areyouok
requested changes
Aug 23, 2024
| @@ -169,15 +165,20 @@ protected CacheResult do_PUT_ALL(Map<? extends K, ? extends V> map, long expireA | |||
| return new CacheResult(future); | |||
| } | |||
|
|
|||
| private CacheResult PUT_caches(int lastIndex, K key, V value, long expire, TimeUnit timeUnit) { | |||
| private CacheResult PUT_caches(int lastIndex, K key, V value, long expire, TimeUnit timeUnit, boolean isForce) { | |||
| CompletableFuture<ResultData> future = CompletableFuture.completedFuture(null); | |||
| for (int i = 0; i < lastIndex; i++) { | |||
| Cache cache = caches[i]; | |||
| CacheResult r; | |||
| if (timeUnit == null) { | |||
| r = cache.PUT(key, value); | |||
There was a problem hiding this comment.
在这里取min （expire，cache的默认expire）比较好，就不用加isForce参数了
There was a problem hiding this comment.
那这样的话，如果用户主动 PUT 一个大于配置时间的过期时间，就不行了。这个 PR 我想到一些边界，还没测试
|
这个还改吗？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #915
TODO:
@Cache(type=BOTH)and not setting localExpire