Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert case insensitive changes #205

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

moxplod
Copy link
Contributor

@moxplod moxplod commented Aug 20, 2024

Description

This is to revert the changes to non-EF LINQ compliant code.

Fixes # #203

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

Copy link

what-the-diff bot commented Aug 20, 2024

PR Summary

  • Update to 'BaseQueryBuilder' and 'LinqQueryBuilder'
    The principle alterations to these files in the Gridify/Builder directory involved the addition of a new isNested parameter to the BuildQuery method; aiding in more complexity while executing queries.

  • Enhancements to String Comparisons
    The LinqQueryBuilder had several adjustments made mainly around string comparisons. Case sensitivity was removed from the Equal and NotEqual operations, and case-insensitive handling was incorporated for the Like and NotLike operations. Additional support was also added for the StartsWith, NotStartsWith, EndsWith, and NotEndsWith operators, thus improving the flexibility of string comparisons.

  • Simplification of Methods within 'MethodInfoHelper'
    In the MethodInfoHelper.cs file located in the src/Gridify/Reflection directory, several methods were removed for simplicity. A new GetToLowerMethod was added to get the ToLower method of string type, providing a streamline operation to change strings to lower case.

  • Test file and adjustments
    There was a deletion of the Issue193Tests.cs file in the test/EntityFrameworkPostgreSqlIntegrationTests directory. A test called ApplyFiltering_GreaterThanOrEqual_CaseInsensitive_BetweenTwoStrings in the GridifyExtensionsShould.cs file has been modified to use StringComparison.OrdinalIgnoreCase, therefore improving test coverage and accuracy.

@moxplod
Copy link
Contributor Author

moxplod commented Aug 20, 2024

If we take these changes we will have to reopen issue #193

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added these tests commented here to uncomment later when we fix #193

Copy link
Owner

@alirezanet alirezanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💐

@alirezanet alirezanet merged commit 0ae1c86 into alirezanet:master Aug 21, 2024
3 checks passed
@moxplod moxplod deleted the revert_case_insensitive_changes branch August 29, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants