Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple bug fixes - exists with case sensitivity and primitive != operator #206

Merged

Conversation

moxplod
Copy link
Contributor

@moxplod moxplod commented Aug 22, 2024

Description

Fixed couple issues one involving case in-sensitivity logic. One involving primitives.

Fixes # #204
#202

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

Copy link

what-the-diff bot commented Aug 22, 2024

PR Summary

  • Enhanced Code Safety in BaseQueryBuilder
    Null check added to string value in src/Gridify/Builder/BaseQueryBuilder.cs. This prevents potential crashes when certain data is not available.

  • Improved Reliability in LinqQueryBuilder
    Added a null check to the Not Contains expression in src/Gridify/Builder/LinqQueryBuilder.cs. This ensures that the software continues to function correctly even if unexpected situations arise.

  • Extended Sample Data For Testing
    New data item was added to the sample data in test/Gridify.Tests/GridifyExtensionsShould.cs. This helps in testing more scenarios and ensuring the robustness of the application.

  • Added New Test Cases For Identified Issues
    New test scenarios have been added in test/Gridify.Tests/IssueTests/Issue202Tests.cs and test/Gridify.Tests/IssueTests/Issue204Tests.cs. These will allow us to be confident that these specific issues have been dealt with correctly and will not reoccur in the future.

@moxplod moxplod marked this pull request as ready for review August 22, 2024 00:28
Copy link
Owner

@alirezanet alirezanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌💐

@moxplod
Copy link
Contributor Author

moxplod commented Aug 23, 2024

@alirezanet Great, please merge it when you can. I do not have permissions to.

@alirezanet alirezanet merged commit 7560fc2 into alirezanet:master Aug 23, 2024
3 checks passed
@moxplod moxplod deleted the 202_exists_with_case_sensitivity branch August 29, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants