Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative date time feature #212

Closed
wants to merge 2 commits into from

Conversation

moxplod
Copy link
Contributor

@moxplod moxplod commented Aug 29, 2024

Description

Relative date time feature. We are able to do filtering such as 'date > today' or 'date > last month'

Fixes # (Relative dates feature #211)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

Copy link

what-the-diff bot commented Aug 29, 2024

PR Summary

  • Added ability to parse relative dates in queries

    A new method named ParseRelativeDate was incorporated into BaseQueryBuilder.cs. This method was designed to convert relative dates into actual date-time values, enhancing the software's functionality and allowing more flexibility in input formats.

  • Improved handling of DateTime values

    The AddIndexerNullCheck method, also located in BaseQueryBuilder.cs, was improved to better handle DateTime values. Now, it is capable of parsing these as relative dates. This enhancement ensures accurate and reliable date-time processing within the software.

  • Integration of the Chronic.Core package

    The Chronic.Core package was added to Gridify.csproj, increasing our project's capability to handle natural language dates, which greatly benefits end-user experience.

  • Enhancements in testing capabilities

    The test file GridifyExtensionsShould.cs now includes two additional test methods: ApplyFiltering_DateTime and ApplyFiltering_DateTime_Relative. These methods are used to verify that the software filters based on "DateTime" values accurately. This addition ensures that our software stays robust and reliable, delivering consistent output.

@moxplod
Copy link
Contributor Author

moxplod commented Aug 29, 2024

If the code and dependency looks good I will go ahead and add the appropriate documentation.

@moxplod
Copy link
Contributor Author

moxplod commented Aug 30, 2024

Closing this - see comments on #211

@moxplod moxplod closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant