Remove all traces of old Sidekiq "worker" naming #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidekiq::Worker was deprecated a while back and [we switched over](1817374) to using Sidekiq::Job here and moved this file from app/workers. I assume there's a reason that we kept these bits when we made those changes. Some sort of compatibility issue? Anyway, this setup is now preventing RSpec from running at all on my machine. (I think it's the difference between the naming of the MappingsBatchJob constant and its file.) So I'm hoping that it's not needed anymore.
|
Ooh, good spot. Aliases were added temporarily so already queued jobs (with the old name) wouldn't fail when the new code was deployed. I should've removed the alias after deploying the new code. |
brucebolt
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidekiq::Worker was deprecated a while back and
we switched over
to using Sidekiq::Job here and moved this file from app/workers.
I assume there's a reason that we kept these bits when we made those
changes. Some sort of compatibility issue?
Anyway, this setup is now preventing RSpec from running at all on my
machine. (I think it's the difference between the naming of the
MappingsBatchJob constant and its file.) So I'm hoping that it's not
needed anymore.