Skip to content

Commit

Permalink
update mac app release config
Browse files Browse the repository at this point in the history
  • Loading branch information
imolorhe committed Sep 24, 2023
1 parent 1b2cdc9 commit 890e7d3
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ env.NODE_VERSION }}
- uses: maxim-lobanov/setup-xcode@v1
if: startsWith(matrix.os, 'macos')
with:
xcode-version: latest-stable
- run: yarn --frozen-lockfile --network-timeout 1000000
- uses: nick-invision/retry@v2
with:
Expand Down Expand Up @@ -66,8 +70,10 @@ jobs:
max_attempts: 3
env:
# macOS notarization API key
API_KEY_ID: ${{ secrets.apple_api_key_id }}
API_KEY_ISSUER_ID: ${{ secrets.apple_api_key_issuer_id }}
# https://www.codiga.io/blog/notarize-sign-electron-app/
APPLE_ID: ${{ secrets.apple_id }}
APPLE_ID_PASSWORD: ${{ secrets.apple_id_password }}
APPLEIDPASS: ${{ secrets.apple_id_password }}
APPLETEAMID: ${{ secrets.apple_team_id }}
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_TOKEN }}

Expand Down
2 changes: 1 addition & 1 deletion packages/altair-api/src/stripe/stripe.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export class StripeService {

constructor() {
this.stripe = new Stripe(process.env.STRIPE_SECRET_KEY!, {
apiVersion: '2022-11-15',
apiVersion: '2023-08-16',
});
}

Expand Down
6 changes: 2 additions & 4 deletions packages/altair-electron/scripts/notarize.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@ exports.default = async function notarizing(context) {
tool: 'notarytool',
appBundleId: 'com.xkoji.altair',
appPath: `${appOutDir}/${appName}.app`,
// appleId: process.env.APPLEID,
// appleIdPassword: process.env.APPLEIDPASS,
appleApiKeyId: process.env.API_KEY_ID,
appleApiIssuer: process.env.API_KEY_ISSUER_ID,
appleId: process.env.APPLE_ID,
appleIdPassword: process.env.APPLE_ID_PASSWORD,
teamId: process.env.APPLETEAMID,
}).then(res => console.log('Notarization completed!') || res);
};

0 comments on commit 890e7d3

Please sign in to comment.