-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade electron to v33 #2738
Upgrade electron to v33 #2738
Conversation
Reviewer's Guide by SourceryThis PR upgrades Electron from v27 to v33.2.1 and includes related dependency updates and error handling improvements. The changes focus on better error logging for process crashes and CSP header handling. Class diagram for updated logging in ElectronAppclassDiagram
class ElectronApp {
+ElectronApp()
+initializeWindow()
+handleOpenUrlEvent(url: string)
+app.on('render-process-gone', event, webContents, details)
+app.on('child-process-gone', event, details)
}
class WindowManager {
+WindowManager()
+registerProtocol()
+instance.webContents.on('render-process-gone', e, details)
}
class LogUtils {
+log(...args: unknown[])
+error(...args: unknown[])
}
ElectronApp --> LogUtils
WindowManager --> LogUtils
Class diagram for updated WindowManagerclassDiagram
class WindowManager {
+WindowManager()
+registerProtocol()
+instance.webContents.on('render-process-gone', e, details)
+validateAppSettings(data)
+updateAltairSettingsOnFile(data)
}
class LogUtils {
+log(...args: unknown[])
+error(...args: unknown[])
}
WindowManager --> LogUtils
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imolorhe - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Visit the preview URL for this PR (updated for commit db37370): https://altair-gql--pr2738-imolorhe-upgrade-ele-30crf345.web.app (expires Sat, 21 Dec 2024 23:18:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 02d6323d75a99e532a38922862e269d63351a6cf |
Fixes
Checks
yarn test-build
Changes proposed in this pull request:
Summary by Sourcery
Upgrade Electron to version 33.2.1 and update related dependencies. Add error logging for render and child process termination events in the Electron app. Refactor logging utility to include an error logging function.
New Features:
Enhancements: