Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the Project to React #101

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Changing the Project to React #101

wants to merge 8 commits into from

Conversation

H-SM
Copy link
Contributor

@H-SM H-SM commented Oct 13, 2023

This PR is for completion of the issue #16 ... Currently undergoing fixes needed to change to a React application (I have made a copy of the project in react for now...

@amittri1025
Copy link
Owner

Kindly add the working of the project in a screen recording.

@H-SM
Copy link
Contributor Author

H-SM commented Oct 13, 2023

hey @amittri1025 , I have currently done like 60% of the work rn... after it's done ill do it

@H-SM
Copy link
Contributor Author

H-SM commented Oct 16, 2023

hey @amittri1025, i finished up converting the application to React now... I fixed up all the conflicts in the css, added all the working of the application.

I have made a seperate folder of react-env so that the application doesn't conflict with the other ongoing changes over it ..
One thing, I wasn't able to express the EmojiPicker over it. I tried making an instance of it,but it didn't go the way I intended it to... We could create up another issue for it.. Except that I fixed up all the other requirements. Hope it reached your expectation, as it took time for me to finish it up... There was also many tiny bugs in a few links, I fixed them up as well.

here's the current working of it ->

2023-10-16.22-59-27.mp4

Ps.: don't forget to mark the PR as hacktoberfest-accepted . Have a great day.

@H-SM
Copy link
Contributor Author

H-SM commented Oct 17, 2023

hey @amittri1025, I looked into EmojiPicker further today... I could try replacing the existing one with npm's emoji-picker-react. Here is its documentation if you wish to have a look over it -> link here

I feel this would be a much better approach over the existing one... It will firstly clear up 7k+ LOC in the codebase and this component has a lot more to offer... I could create a issue over this and work on it further, that would be great.

@H-SM
Copy link
Contributor Author

H-SM commented Oct 18, 2023

hey @amittri1025, it would be great if you could review this PR & also look over the issue in hand. Thanks..

@H-SM
Copy link
Contributor Author

H-SM commented Oct 21, 2023

hey @amittri1025, I saw the new changes done in the webpage, Ill update up the source code for the application for them soon...
It would be great if you could look over my issue here. Thanks.

@H-SM H-SM closed this Nov 13, 2023
@H-SM H-SM reopened this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants