Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated license header for all relevant files. Updated pre-commit yam… #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SrikanthPagadarai
Copy link
Collaborator

…l file.

Updated doc cmake file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes seem incorrect for the file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

log () : m_log{}, m_flag{ false } {}

public:
bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return types all inconsistent between files. I would say they look better on the same line as the function definition and not on a separate line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@SrikanthPagadarai SrikanthPagadarai force-pushed the pre-commit-update branch 2 times, most recently from 917bd38 to 13a2420 Compare December 20, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants