Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shell Exit & Python packages #20

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

gvatsal60
Copy link
Contributor

No description provided.

@andmpel
Copy link
Owner

andmpel commented Oct 28, 2024

Do we want to allow modifying the system pip packages? I feel like research needs to be done to see the implications of this. Best practices for python scripting typically involve creating a virtual environment where pip packages are managed. Might be worth considering even removing pip update all together. Will update when I have time to look into this.

Removed python pip as newer versions of python require either breaking the system environment (which is not recommended) or creating virtual environments per project.
@andmpel andmpel merged commit 1ef41a4 into andmpel:master Oct 28, 2024
3 checks passed
@gvatsal60
Copy link
Contributor Author

Do we want to allow modifying the system pip packages? I feel like research needs to be done to see the implications of this. Best practices for python scripting typically involve creating a virtual environment where pip packages are managed. Might be worth considering even removing pip update all together. Will update when I have time to look into this.

As far as I understood the script is to update system packages and also pip >= 24+ won't allow any package to be installed system wide and even for user.

It should be installed either through virtualenv or pipx.

I feel there is no harm till the user knows while using the script.

@gvatsal60 gvatsal60 deleted the fix/python branch October 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants