Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix #369

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Klwnt
Copy link

@Klwnt Klwnt commented Jun 16, 2022

SUMMARY

Fixes #368 , network_cli module failing on EOS 4.26+ versions due to a warning message originating from setting a TCAM profile. Additionally, the performance of the module is considerably improved as commands are not passed line by line, but as a single blob.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cliconf

ADDITIONAL INFORMATION

The change made refers to what has been suggested in issue #368. Step by step reproduction instructions are also indicated there.

Same for the command output.

@KB-perByte KB-perByte requested a review from GomathiselviS June 22, 2022 10:03
@GomathiselviS
Copy link
Contributor

Hello @Klwnt , Using copy terminal: session-config can be a new feature. Replacing the existing logic with this command is going to affect many modules.

To fix the issue mentioned in #368 , edit_config can be modified to accept prompt as an argument and pass it over to send_command. You can refer to the get function - https://github.com/ansible-collections/arista.eos/blob/main/plugins/cliconf/eos.py#L182

@Klwnt
Copy link
Author

Klwnt commented Aug 9, 2022

Hello @GomathiselviS , I'm not 100% certain to understand what you mean. I see how the prompt argument can be passed on to send_command, but not how, from there, we get to use copy terminal: session-config. Could you please explain in a few words how this will work ?

@Ruchip16 Ruchip16 marked this pull request as draft April 24, 2024 10:18
@Ruchip16 Ruchip16 requested review from roverflow and removed request for GomathiselviS April 24, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config replace fails when TCAM profile commands are present when using network_cli
2 participants