fix(eos_config): change value validationfor parameter diff_against with value validate_config #503
Conversation
|
ready to review |
philippebureau
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 153 153
Lines 11967 11967
=======================================
Hits 9904 9904
Misses 2063 2063 ☔ View full report in Codecov by Sentry. |
|
@philippebureau Thank for the contribution. Could you please changelog and test it if possible? |
for more information, see https://pre-commit.ci
done |
|
@philippebureau This looks good, thanks for adding the changelog, could you please also add the integration test, |
|
the
the diff_against already had a an integration test. here The assertion in the current test is valid. Does the test need to be extended? |
|
@cidrblock as per discussed today at Redhat summit |
SUMMARY
fixes #501
changing the value against what the module test for "replace" to append "rollback clean-config"
The previous behaviour was causing the module not to append "rollback clean-config" with method "get_session_config"
The returned "after" value was a sum of running-config + intended_config which makes the diff between before and after innacurate
ISSUE TYPE
COMPONENT NAME
eos_config / diff_against
ADDITIONAL INFORMATION
change the replace conditional value check to allows the returned "after" value to show the actual intended config and not a merge of intended and running-config