This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
1.0.5 #37
Open
1.0.5 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luozhou (Siyuan Cao) <[email protected]>
Signed-off-by: Luozhou (Siyuan Cao) <[email protected]>
Signed-off-by: Luozhou (Siyuan Cao) <[email protected]>
yibuyisheng
suggested changes
Aug 27, 2020
| */ | ||
| observe( | ||
| targetSelector: string, | ||
| callback: (res: IObserveResult) => any, |
There was a problem hiding this comment.
有的时候就用箭头函数的，感觉用 void 会限制这个地方？
my.createIntersectionObserver()
.relativeToViewport()
.observe('.className', node => this.nodes.push(node)) // <- 用 void 会报错
types/component.d.ts
Outdated
| @@ -69,31 +69,32 @@ declare namespace tinyapp { | |||
| $spliceData: SpliceDataMethod; | |||
| } | |||
|
|
|||
| type ComponentOptions< | |||
| interface InternalComponentOptions<P, D, M> { | |||
There was a problem hiding this comment.
IInternalComponentOptions
Signed-off-by: Luozhou (Siyuan Cao) <[email protected]>
Signed-off-by: Luozhou (Siyuan Cao) <[email protected]>
yibuyisheng
reviewed
Mar 1, 2021
| * @file IntersectionObserver 对象，用于推断某些节点是否可以被用户看见、有多大比例可以被用户看见。 | ||
| */ | ||
| declare namespace my { | ||
| namespace intersectionObserver { |
yibuyisheng
reviewed
Mar 1, 2021
| selectAll?: boolean; | ||
| } | ||
|
|
||
| interface IRect { |
There was a problem hiding this comment.
IRect -> IIntersectionObserverRect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要变更
my.createIntersectionObserver及相关类型的声明。Refactor
ComponentOptions重构为 interface 以便业务自行扩展。