Add documentation for NodeLatencyMonitor feature #6561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @IRONICBo |
antoninbas
added
kind/documentation
luolanzone
reviewed
Jul 29, 2024
docs/feature-gates.md
Outdated
| pingIntervalSeconds: 60 | ||
| ``` | ||
|
|
||
| You can adjust `pingIntervalSeconds` to your desired value. To stop latency measurements, simply |
There was a problem hiding this comment.
Suggested change
| You can adjust `pingIntervalSeconds` to your desired value. To stop latency measurements, simply | |
| You can adjust `pingIntervalSeconds` to any positive value that suits your needs. To stop latency measurements, simply |
| apiVersion: stats.antrea.io/v1alpha1 | ||
| kind: NodeLatencyStats | ||
| metadata: | ||
| creationTimestamp: null |
There was a problem hiding this comment.
Maybe remove this line?
There was a problem hiding this comment.
This is the current output of the command, so we should not hand modify it manually for the documentation.
However, we could look into setting it correctly in the REST server, as a subsequent PR.
docs/feature-gates.md
Outdated
Comment on lines
512
to
513
| policyOnly mode is used), inter-Node latency will be measured between Antrea gateway | ||
| interfaces. Therefore, in encap mode, ICMP probes will traverse the overlay, just like regular |
There was a problem hiding this comment.
Suggested change
| policyOnly mode is used), inter-Node latency will be measured between Antrea gateway | |
| interfaces. Therefore, in encap mode, ICMP probes will traverse the overlay, just like regular | |
| `networkPolicyOnly` mode is used), inter-Node latency will be measured between Antrea gateway | |
| interfaces. Therefore, in `encap` mode, ICMP probes will traverse the overlay, just like regular |
The feature is quite simple at the moment, so maybe no need for a dedicated documentation page. Fixes antrea-io#6551 Signed-off-by: Antonin Bas <[email protected]>
Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
add-documentation-for-nlm
branch
from
cc1e719 to
011fbf0
Compare
luolanzone
approved these changes
Jul 30, 2024
|
/skip-all |
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Jul 30, 2024
The feature is quite simple at the moment, so maybe no need for a dedicated documentation page. Fixes antrea-io#6551 Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
that referenced
this pull request
Jul 30, 2024
The feature is quite simple at the moment, so maybe no need for a dedicated documentation page. Fixes #6551 Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature is quite simple at the moment, so maybe no need for a dedicated documentation page.
Fixes #6551