Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] adding a new workflow to validate the FlexibleIPAM feature #6879

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KMAnju-2021
Copy link
Contributor

@KMAnju-2021 KMAnju-2021 commented Dec 19, 2024

@KMAnju-2021 KMAnju-2021 marked this pull request as draft December 19, 2024 06:33
- name: Load Antrea image
run: |
docker load -i antrea-ubuntu.tar
- name: Install Kind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use GitHub Actions caching to avoid re-downloading tools like Kind in every run, which can save build time

uses: actions/download-artifact@v4
with:
name: antrea-ubuntu-cov
- name: Load Antrea image
Copy link
Contributor

@rajnkamr rajnkamr Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- name: Validate Antrea image file
  run: |
    if [ ! -f antrea-ubuntu.tar ]; then
      echo "Error: antrea-ubuntu.tar not found. Ensure the image artifact was downloaded correctly."
      exit 1
    fi

steps:
- name: Free disk space
# https://github.com/actions/virtual-environments/issues/709
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention specific disk space needed to run ipam tests in cncf runners

- name: Verify sufficient disk space
  run: |
    AVAILABLE_SPACE=$(df --output=avail / | tail -n1)
    if [ "$AVAILABLE_SPACE" -lt 5000000 ]; then 
      echo "Insufficient disk space for the tests."
      exit 1
    fi

@rajnkamr rajnkamr added this to the Antrea v2.3 release milestone Dec 26, 2024
@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 22 times, most recently from 33a2b50 to 9486da3 Compare January 2, 2025 04:30
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR is misleading: we are adding a new workflow to validate the FlexibleIPAM feature. The fact that we use a non-default runner is an "implementation detail".

needs: [build-antrea-coverage-image]
runs-on: [ubuntu-latest-4-cores]
steps:
- name: Free disk space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this step, unless you know that there is a shortage of disk space on these runners

ci/kind/install-ipset.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Outdated Show resolved Hide resolved
ci/kind/kind-setup.sh Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 changed the title [WIP] adding self-hosted runners [WIP] adding a new workflow to validate the FlexibleIPAM feature Jan 3, 2025
@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 17 times, most recently from 5d9fdec to 2a52628 Compare January 7, 2025 06:47
Signed-off-by: KMAnju-2021 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants