Reduce unnecessary public visibility of some SVM structs and APIs #4308
+47
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
approved these changes
Jan 7, 2025
buffalojoec
reviewed
Jan 8, 2025
| @@ -11,7 +11,7 @@ use { | |||
| }; | |||
|
|
|||
| #[derive(Debug, Default, Clone, serde_derive::Deserialize, serde_derive::Serialize)] | |||
| pub struct MessageProcessor {} | |||
| pub(crate) struct MessageProcessor {} | |||
There was a problem hiding this comment.
I believe some people use MessageProcessor::process_message in their libraries, such as LiteSVM. Any objection to keeping this one public, and just keeping it within the "not guaranteed under SemVer" band?
cc @kevinheavey
There was a problem hiding this comment.
I would like MessageProcessor to be pub yes. But I guess I was already planning on copy-pasting it since litesvm doesn't use anything else from solana-svm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some structs and APIs in SVM do not need to be
pub.Summary of Changes
Reduce the visibility to private or
pub(crate).Fixes #