[FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syhily
suggested changes
Apr 22, 2024
pom.xml
Outdated
| <dependency> | ||
| <groupId>commons-io</groupId> | ||
| <artifactId>commons-io</artifactId> | ||
| <version>2.15.1</version> |
There was a problem hiding this comment.
Move the version to the properties.
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| <version>3.14.0</version> |
There was a problem hiding this comment.
Move the version to the properties.
syhily
suggested changes
Apr 26, 2024
| @@ -49,7 +49,7 @@ public Foo() {} | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| return "" + i + "," + f + "," + (bar == null ? "null" : bar.toString()); | |||
| return i + "," + f + "," + (bar == null ? "null" : bar.toString()); | |||
There was a problem hiding this comment.
I prefer to do only one thing in one PR. This refactor shouldn't be included in the version bump.
There was a problem hiding this comment.
Because ci failed ,I just modify code to trigger ci. Now,This code had been reverted.
|
OK, LGTM. We need to get the CI pass, finally. |
…1.26.1 for Flink Pulsar connector
|
@syhily CI passed~ |
syhily
approved these changes
Apr 28, 2024
tisonkun
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #83.