IGNITE-23655 Introduce CacheIdleVerifyCancelCommand #11673
Conversation
nizhikov
changed the title
| /** | ||
| * Cancels idle_verify command. | ||
| */ | ||
| public class CacheIdleVerifyCancelCommand implements ComputeCommand<NoArg, Void>, Serializable { |
There was a problem hiding this comment.
Whe command implement Serializable?
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public String description() { | ||
| return "Cancels idle_verify command."; |
There was a problem hiding this comment.
Please, remove, dot in the end of line.
|
|
||
| /** {@inheritDoc} */ | ||
| @Override protected Void run(NoArg arg) { | ||
| if (idleVerifyId().isPresent()) |
There was a problem hiding this comment.
Can be replaced with ifPresent
|
|
||
| int idleVerifyCnt = 0; | ||
|
|
||
| for (ComputeTaskView view : srv.context().systemView().<ComputeTaskView>view(TASKS_VIEW)) { |
There was a problem hiding this comment.
System view are local.
Let's iterate started servers and check them all.
There was a problem hiding this comment.
checked all servers
| for (int i = 0; i < 100000; i++) | ||
| cache.put(i, i); | ||
|
|
||
| new Thread(() -> execute("--cache", "idle_verify") ).start(); |
There was a problem hiding this comment.
--cache idle_verify don't return while command ends?
If yes, we need to do the following:
- Start with
GridTestUtils.runAsyncwhich returns Future. - Check future not done.
- Cancel command.
- Check future done.
- Other checks for all servers.
There was a problem hiding this comment.
- Check future done.
AFAICS this not implemented.
.../src/main/java/org/apache/ignite/internal/management/cache/CacheIdleVerifyCancelCommand.java
Outdated
Show resolved
Hide resolved
|
We have some tests that check Did you got bot visa for this PR? |
vladnovoren
force-pushed
the
ignite-23655
branch
from
82cce7f to
3afb342
Compare
…ts cancelling is printed in ouput.
|
|
||
| srv.cluster().state(ACTIVE); | ||
|
|
||
| IgniteCache<Integer, Integer> cache = srv.createCache(DEFAULT_CACHE_NAME); |
There was a problem hiding this comment.
Default backup count are 0.
Which means idle_verify will run on one node only.
Let's configure gridsCnt == CacheConfiguration.backup == 3 in this test.
vladnovoren
force-pushed
the
ignite-23655
branch
from
6e3add7 to
9a0a1c7
Compare
vladnovoren
force-pushed
the
ignite-23655
branch
from
9a0a1c7 to
1bf8664
Compare
…sn't track views.
…upPartitionJobV2#execute.
vladnovoren
force-pushed
the
ignite-23655
branch
from
e455147 to
f583f41
Compare
…er task views (it seems to be unnecessary). Added log listener and it fails.
vladnovoren
force-pushed
the
ignite-23655
branch
from
6938157 to
602e674
Compare
…passed except cases when idle verify command is finished immediately (before idle verify --cancel is called).
…. Also added testIdleVerifyTrackedForkJoinPool that waits on beforeCancelLatch.await(). Overriden submit method for custom ForkJoinPool is not reached although pool.submit in calculatePartitionHashAsync is reached.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.