IGNITE-23744 .NET: Add cluster node filters for PlatformCache #11685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptupitsyn
approved these changes
Nov 27, 2024
| @@ -1064,5 +1064,10 @@ Task<ICollection<ICacheEntryProcessorResult<TK, TRes>>> InvokeAllAsync<TArg, TRe | |||
| /// <param name="partition">Partition number.</param> | |||
| /// <returns><code>True</code>if partition was preloaded, <code>False</code> if it doesn't belong to local node.</returns> | |||
| bool LocalPreloadPartition(int partition); | |||
|
|
|||
| /// <summary> | |||
| /// Returns a value indicating whether this instance has platform cache. | |||
There was a problem hiding this comment.
Suggested change
| /// Returns a value indicating whether this instance has platform cache. | |
| /// Gets a value indicating whether this instance has platform cache. |
| if (NodeFilter is JavaNodeFilter) | ||
| writer.WriteObject<object>(null); | ||
| else | ||
| writer.WriteObject(NodeFilter); |
There was a problem hiding this comment.
Does this support AttributeNodeFilter? Can we add a test?
There was a problem hiding this comment.
@ptupitsyn , good point! I will test it a little bit later. Currently PR is in WIP status.
shishkovilja
force-pushed
the
ignite-23744
branch
from
908696c to
c2e3f38
Compare
shishkovilja
force-pushed
the
ignite-23744
branch
from
8c24586 to
ca3940d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.