Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:add undo protobuf parser #691

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

marsevilspirit
Copy link
Contributor

@marsevilspirit marsevilspirit commented Nov 12, 2024

What this PR does:

add serialization type protobuf

Which issue(s) this PR fixes:

Fixes #473

Special notes for your reviewer:

Protobuf can be used locally to run normally.

Does this PR introduce a user-facing change?:

The undo log serialization method can be changed to protobuf through the configuration file.

@luky116 luky116 removed the coding label Nov 23, 2024
@kaori-seasons
Copy link
Contributor

kaori-seasons commented Nov 23, 2024

@marsevilspirit Is it possible to add some integration tests? For example, tcc mode uses protobuf to serialize undolog

@marsevilspirit
Copy link
Contributor Author

@marsevilspirit Is it possible to add some integration tests? For example, tcc mode uses protobuf to serialize undolog

When seata-go releases a new version, I will try to write an integration test to verify whether protobuf serialization can run correctly.

@github-actions github-actions bot added the coding label Dec 5, 2024
@marsevilspirit
Copy link
Contributor Author

apache/incubator-seata-go-samples#57

add an integration test about at mode uses protobuf to serialize undolog.

@luky116 luky116 merged commit 0fa0272 into apache:master Dec 7, 2024
7 checks passed
@marsevilspirit marsevilspirit deleted the feature-undo-protobuf-parser branch December 21, 2024 08:39
@slievrly slievrly added this to the 2.0.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add serialization type protobuf
4 participants