SOLR-16505: Add auth listener to RecoveryStrategy SolrClient #2462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16505
As previously noticed that whenever we re-create Solr client using existing
Http2SolrClient
then no listeners were passed to the newHttp2SolrClient
object. To fix this, a new code(withListenerFactory
method inHttp2SolrClient#Builder
class) is added to previous commit for SOLR_16505. However, It did not called this new method for client in RecoveryStrategy. Therefore all the calls that were made from RecoveryStrategy were failing in case if auth is enabled.Tests
A new test case is added to configure SolrCloud with a security.json file. A specific test condition is tested where after indexing good amount of document, a new replica is added which would trigger RecoveryStrategy for it and everything is happening when auth is enabled.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.