-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(filter): adding inputs to Numerical Range Filter #31726
base: master
Are you sure you want to change the base?
refactor(filter): adding inputs to Numerical Range Filter #31726
Conversation
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
@alexandrusoare would it be a good idea to make the inputs optional? Especially in horizontal filter bar orientation the added inputs may be problematic. |
@villebro I think having both the slider and the inputs offer greater control to the user, it's hard setting values just from the slider alone. For the horizontal bar I do agree that it doesn't look good, so what I propose is to have the slider next to the inputs instead of having them one on top of the other. Let me know what you think about this |
I agree with @villebro actually - the plan was to get rid of the slider entirely as it's not really an easy to use pattern. Inputs are better in terms of usability and precision. I think keeping both adds to the clutter and we already have a lot of different elements in this dashboard view. |
Fixes #31345
SUMMARY
Adding inputs to the Numerical Range Filter
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION