Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(filter): adding inputs to Numerical Range Filter #31726

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alexandrusoare
Copy link
Contributor

@alexandrusoare alexandrusoare commented Jan 6, 2025

Fixes #31345

SUMMARY

Adding inputs to the Numerical Range Filter

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
image

AFTER
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Jan 6, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. hold! On hold labels Jan 6, 2025
@villebro
Copy link
Member

villebro commented Jan 6, 2025

@alexandrusoare would it be a good idea to make the inputs optional? Especially in horizontal filter bar orientation the added inputs may be problematic.

@alexandrusoare
Copy link
Contributor Author

@alexandrusoare would it be a good idea to make the inputs optional? Especially in horizontal filter bar orientation the added inputs may be problematic.

@villebro I think having both the slider and the inputs offer greater control to the user, it's hard setting values just from the slider alone. For the horizontal bar I do agree that it doesn't look good, so what I propose is to have the slider next to the inputs instead of having them one on top of the other. Let me know what you think about this

@kasiazjc
Copy link
Contributor

kasiazjc commented Jan 7, 2025

@alexandrusoare would it be a good idea to make the inputs optional? Especially in horizontal filter bar orientation the added inputs may be problematic.

@villebro I think having both the slider and the inputs offer greater control to the user, it's hard setting values just from the slider alone. For the horizontal bar I do agree that it doesn't look good, so what I propose is to have the slider next to the inputs instead of having them one on top of the other. Let me know what you think about this

I agree with @villebro actually - the plan was to get rid of the slider entirely as it's not really an easy to use pattern. Inputs are better in terms of usability and precision. I think keeping both adds to the clutter and we already have a lot of different elements in this dashboard view.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold! On hold preset:bounty Issues that have been selected by Preset and have a bounty attached. review:draft size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update filter numerical range slider to user input fields
5 participants