-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed path issue in import kvm, #303 #304 #305
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the folders and kvm files:
kvm-import-tests/
├── kvms-env
│ └── env_bu1-test_bu1-kvm2_kvmfile_0.json
├── kvms-org
│ └── org_test-org-level2_kvmfile_0.json
└── kvms-proxy
└── proxy_bu1-test-1_bu1-test-1-kvm_kvmfile_0.json
ORG=apigeex-payg-kurt
ENV=bu1-test
PROXY=bu1-test-1
The file names structure being:
env_${ENV}${KVM}kvmfile_0.json
proxy${$PROXY}${KVM}kvmfile_0.json
org${KVM}_kvmfile_0.json
I verified that the following has an error:
apigeecli kvms import --folder=./kvm-import-tests/kvms-proxy --org=$ORG
And that this works:
go run main.go -t=$TOKEN kvms import --folder=./kvm-import-tests/kvms-proxy --org=$ORG
All other imports work too.
Change whitespace to match the file: space --> tab.
Fixed the spacing issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
@aliasgar55 - we will be able to merge once you accept the CLA |
Please run |
It took me a bit to get this installed. When I ran, it flagged an empty line #42 and removed it. |
Fixed issue with import kvm