Skip to content

Commit

Permalink
More logback cleanup, more release notes.
Browse files Browse the repository at this point in the history
  • Loading branch information
Gregory Brail committed Jun 19, 2015
1 parent 49fdadb commit 153b9a3
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 20 deletions.
19 changes: 15 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,14 @@ any native code.
access to the XSLT processor inside your Java platform, which is faster and
can support more of the XSLT standard than libxslt.

## Logging

Trireme uses slf4j for logging the stuff that is happening in Java. The pre-built JAR, and the NPM
"trireme" wrapper, use "slf4j-simple". To turn on debug logging, set the system property
"org.slf4j.simpleLogger.defaultLogLevel" to "debug". (Or "trace" for even more output.)

When embedding trireme, you can use any SLF4J-compatible logging framework you wish, such as logback.

## How Complete is Trireme?

Trireme supports most of the Node.js APIs and passes much of the Node.js test suite.
Expand Down Expand Up @@ -183,10 +191,12 @@ A few of the modules are different, some in major ways:
### JavaScript Language

Trireme runs in the JVM on Rhino, which is the most complete JavaScript implementation for
the JVM. Rhino currently implements version 1.8 of JavaScript, which means that a few things supported
in later versions of JavaScript, such as the "trimLeft" method of the "String" object, are not supported.
the JVM and the one that works on the largest variety of Java distributions. The latest version of Rhino
has many of the new JavaScript language features that Node users are used to, but still does not
have all the features that are supported when the "--harmony" flag is set.

Also, newer features of V8, particularly the primitive array types, are not supported in Rhino.
For specifics, see the [Rhino compatibility table](http://mozilla.github.io/rhino/compat/engines.html).
Trireme is currently using RHino 1.7.7.

Most of the time the differences between V8 and Rhino do not affect Node.js code, but occasionally
there is a problem. We would love some help from the Rhino community to start to address these differences.
Expand Down Expand Up @@ -267,7 +277,7 @@ In addition, the following is also valid, and "trireme-crypto" will not be neede
Like TLS, certain features (Sign/Verify in particular) only work if the "trireme-crypto" module and its
dependencies are in the class path. If they are not present then these methods will throw an exception.
This is primarily because the trireme-crypto module uses Bouncy Castle to implement PEM file reading
and decryption.
and decryption. It is possible to run Trireme without Bouncy Castle if these features are not needed.

### Child Process

Expand Down Expand Up @@ -351,6 +361,7 @@ This table will help keep them straight:
<tr><td><b>module</b></td><td><b>Required?</b></td><td><b>Recommended?</b></td><td><b>Description</b></td></tr>
<tr><td>trireme-core</td><td>X</td><td>X</td><td>The core module containing the guts of Trireme</td></tr>
<tr><td>trireme-node10src</td><td>X</td><td>X</td><td>JavaScript code that makes Trireme implement Node.js 0.10</td></tr>
<tr><td>trireme-node12src</td><td>X</td><td>X</td><td>JavaScript code that makes Trireme implement Node.js 0.12</td></tr>
<tr><td>trireme-crypto</td><td/><td>X</td>
<td>Support code for reading PEM files and some other crypto operations. Uses Bouncy Castle. If not in the classpath,
certain crypto operations (notably PEM file support for TLS and HTTPS) will not work. Nonetheless, this is a separate
Expand Down
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ the main thread rather than by exiting the script. This slows things down but ma
much more robust.
[Issue 114](https://github.com/apigee/trireme/issues/114) Fix TriremeServlet so that it properly reads
large bodies coming from the client without corruption.
[Issue 120](https://github.com/apigee/trireme/issues/120) Speed up Trireme startup.

Also, upgrade to Rhino 1.7.7. This fixes a bug with calling "toJSON" on certain Error objects, and
introduces support for native arrays, among many other things. (Native arrays like Int32Array are
Expand Down
4 changes: 2 additions & 2 deletions nodetests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
4 changes: 2 additions & 2 deletions npm-package/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
</dependency>

<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
</dependency>
</dependencies>

Expand Down
12 changes: 0 additions & 12 deletions npm-package/src/main/resources/lib/logback.xml

This file was deleted.

0 comments on commit 153b9a3

Please sign in to comment.