Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure graphqlErrors always returns a value #1606

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jerelmiller
Copy link
Member

Fixes #1552

I have been unable to reproduce this myself since ApolloError.graphQLErrors is supposed to always be an array, but I've added a defensive fallback when serializing the error to ensure we always have a value.

@jerelmiller jerelmiller requested a review from a team as a code owner December 20, 2024 17:16
Copy link

relativeci bot commented Dec 20, 2024

#1100 Bundle Size — 1.63MiB (~+0.01%).

59e3496(current) vs 2535670 main#1098(baseline)

Warning

Bundle contains 13 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#1100
     Baseline
#1098
Regression  Initial JS 1.49MiB(~+0.01%) 1.49MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 0.99% 0%
No change  Chunks 5 5
No change  Assets 157 157
No change  Modules 1228 1228
No change  Duplicate Modules 45 45
No change  Duplicate Code 3.12% 3.12%
No change  Packages 183 183
No change  Duplicate Packages 10 10
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#1100
     Baseline
#1098
Regression  JS 1.49MiB (~+0.01%) 1.49MiB
No change  Other 100.55KiB 100.55KiB
No change  IMG 35.85KiB 35.85KiB
No change  HTML 857B 857B

Bundle analysis reportBranch jerel/fix-some-bugsProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

pkg-pr-new bot commented Dec 20, 2024

npm i https://pkg.pr.new/apollographql/apollo-client-devtools@1606
npm i https://pkg.pr.new/apollographql/apollo-client-devtools/@apollo/client-devtools-vscode@1606

commit: 59e3496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot return null for non-nullable field SerializedApolloError.graphQLErrors.
1 participant