Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check against ENV variable DEBUG being true, instead of not being null #5637

Conversation

fmorenodesigns
Copy link

@fmorenodesigns fmorenodesigns commented Oct 16, 2023

Description

There's a lot of console noise being printed, even when setting the DEBUG variable to false. I see that there are other places where the check against true rather than != null is already done, and can't think of any downsides to this. Although this probably should never bleed into the production build to begin with 🤔

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

I skipped some of the bureaucracy as I believed it not necessary for this kind of change. This is my first time contributing so please let me know.

There's a lot of console noise being printed, even when setting the
DEBUG variable to `false`. I see that there are other places where the
check against `true` rather than `!= null` is already done, and can't
think of any downsides to this.
@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 9390e8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant