Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button type #59

Merged
merged 4 commits into from
Nov 21, 2023
Merged

fix: button type #59

merged 4 commits into from
Nov 21, 2023

Conversation

manolo-battista
Copy link
Member

Description

Extend type of button using HTMLElementButton type, and set "button" as default

@manolo-battista manolo-battista requested a review from a team as a code owner November 21, 2023 14:24
Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 05b974e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@arkejs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ilyichv
Copy link
Member

ilyichv commented Nov 21, 2023

Extend this props

React.ButtonHTMLAttributes<HTMLButtonElement>

@manolo-battista manolo-battista merged commit 8454506 into main Nov 21, 2023
1 check passed
@manolo-battista manolo-battista deleted the fix/button branch November 21, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants