Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support rusqlite 0.32 #24

Closed
wants to merge 1 commit into from

Conversation

nuttycom
Copy link
Contributor

I've been wondering: would it make sense to create a release for each semver-incompatible rusqlite version? That way it's at least possible for users of the crate to get one that works with their stack.

@aschampion If it would be helpful I would like to offer to become a co-maintainer of the schemer and schemer-rusqlite crates on crates.io; I use these crates extensively both for work and personal projects, and would like to be able to make sure they work for as many users as possible.

@str4d
Copy link

str4d commented Oct 2, 2024

CI failure is due to MSRV incompatibility.

rusqlite 0.29 depends on hashlink 0.8; rusqlite 0.31 migrated to hashlink 0.9.

hashlink 0.8.2 migrated from hashbrown 0.12 (MSRV 1.56) to hashbrown 0.13 (MSRV 1.61). hashlink 0.8.3 migrated again to hashbrown 0.14 (MSRV 1.63). That dependency is maintained in hashlink 0.9.

Ergo, if we only migrated to rusqlite 0.30 then current MSRV of 1.59 could be maintained (as there exists a compatible hashlink version). Latest rusqlite unfortunately has a required MSRV of 1.63.

@str4d
Copy link

str4d commented Oct 16, 2024

The necessary sequence of MSRV bumps (and associated dependency versions) can be found here: zcash/schemerz#4

@nuttycom
Copy link
Contributor Author

Closing; using zcash/schemerz instead.

@nuttycom nuttycom closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants