Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancements in android keyboard interaction #376

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

shadow578
Copy link

this PR introduces two enhancements related to how the app interacts with the on-screen keyboard on android devices.

1. enable suggestions in form fields

currently, form fields (e.g. the title field when uploading a new document) do not show any suggestions while typing.
this means that there's no autocorrect and swipe typing is rendered completely useless.

this is caused by the FormBuilderTextField's enableSuggestions property being set to false.
since the docs don't mention a default value for this property, i'm assuming that the default is simply false.

explicitely setting enableSuggestions to true makes the suggestions work (see Fig. A), so i simply added it to all uses of the FormBuilderTextField.
This includes (but may not be limited to):

  • the 'Title' and 'File Name' fields when uploading a new document
  • the 'Title' field when editing a document
  • the 'Name' fields when creating a new correspondent, document type, or label

2. enable autofill of user credentials in login form

this one is quite simple because i've just added an AutofillGroup wrapping the FormBuilderField of the user credentials form shown when adding a new user.
This makes autofill suggestions show up on the keyboard normally (see Fig. B).

upload-doc-suggestions login-autofill-1
(Fig. A) GBoard showing suggestions for 'Title' field on document upload (Fig. B) GBoard showing autofill options on login (Bitwarden). Clicking the entry will autofill the credentials in the app.

@astubenbord
Copy link
Owner

Hi, sorry for the late reply. I'd have merged it already, but I'm currently refactoring most of the forms since they got really hard to maintain. I'll reiterate once I've completed the new forms. Thanks!

@collinjackson93
Copy link

@astubenbord Is the form refactor that blocked this PR still ongoing? If so, is there anything an outside developer could do to assist with that process or addressing merge conflicts with this PR?

@astubenbord
Copy link
Owner

Hi, unfortunately yes, the form refactoring contains quite a lot of changes (not only related to the forms). I'm trying to find the time to work on the app, but i'm still super busy at the moment. Nonetheless I want to spend more time on it again in the future since I couldnt really find the time to work on it for a couple of months. Also paperless has evolved quite a bit and since most users keep their version up to date its practically impossible for me to keep up with development, which is kind of frustrating and demotivating.

@collinjackson93
Copy link

I'm sorry to hear that. Open source maintenance can be somewhat thankless and can create an environment where burnout thrives. I also totally understand not having much time to work on projects and the frustration that can come when your side project becomes used by so many people that your fun experience starts to feel like more work.

I also have limited free time (and very little experience with mobile development), but if you would like some help trying to split your refactor into smaller pieces that can be merged incrementally (I've found that more frequent, small wins help keep me motivated on large projects), I'm happy to help. That said, I hope that offer doesn't come across as pushy in any way. I don't want to force your hand, push for a new release, or step on your project; it's a legitimate, no-strings-attached offer if you want some assistance and no hard feelings if you want to continue working solo when you have the time and motivation.

I think the app is already great and I'm thankful for the care and effort that you've put into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants