DYNAMIC_STREAM_METADATA should be decoupled from streamSettings #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning:
DYNAMIC_STREAM_METADATA configuration should be decoupled from streamSettings.
Current behavior:
when DYNAMIC_STREAM_METADATA is set to true, and streamSettings is not set, the _onXVIZTimeslice throws an error for
in
operatorExpected fix:
We either need to set the default value for
streamSettings
to{}
in constructor, or do a safe check forstreamSettings
as in the diff.