Add Predictive Modeling page and update settings #61

MattG57 · 2024-11-19T02:13:12Z

Add Predictive Modeling page and update navigation menu.

Add PredictiveModelingComponent and update routes in frontend/src/app/app.routes.ts.
Update navigation menu in frontend/src/app/main/main.component.html to include link to Predictive Modeling.
Rename and update frontend/src/app/main/copilot/copilot-calculator/copilot-calculator.component.ts to frontend/src/app/main/copilot/predictive-modeling/predictive-modeling.component.ts.
Rename and update frontend/src/app/main/copilot/copilot-calculator/copilot-calculator.component.html to frontend/src/app/main/copilot/predictive-modeling/predictive-modeling.component.html.
Rename and update frontend/src/app/main/copilot/copilot-calculator/copilot-calculator.component.spec.ts to frontend/src/app/main/copilot/predictive-modeling/predictive-modeling.component.spec.ts.
Add methods to get and update new variables in frontend/src/app/services/settings.service.ts.
Add methods to get and update new variables in backend/src/services/settings.service.ts.
Add methods to get and update new variables in backend/src/controllers/settings.controller.ts.
Create TargetValues model in backend/src/models/target-values.model.ts.
Create TargetValuesController in backend/src/controllers/target-values.controller.ts.
Create TargetValuesService in backend/src/services/target-values.service.ts.
Create routes for TargetValues in backend/src/routes/target-values.routes.ts.

For more details, open the Copilot Workspace session.

Add Predictive Modeling page and update navigation menu. * Add `PredictiveModelingComponent` and update routes in `frontend/src/app/app.routes.ts`. * Update navigation menu in `frontend/src/app/main/main.component.html` to include link to Predictive Modeling. * Rename and update `frontend/src/app/main/copilot/copilot-calculator/copilot-calculator.component.ts` to `frontend/src/app/main/copilot/predictive-modeling/predictive-modeling.component.ts`. * Rename and update `frontend/src/app/main/copilot/copilot-calculator/copilot-calculator.component.html` to `frontend/src/app/main/copilot/predictive-modeling/predictive-modeling.component.html`. * Rename and update `frontend/src/app/main/copilot/copilot-calculator/copilot-calculator.component.spec.ts` to `frontend/src/app/main/copilot/predictive-modeling/predictive-modeling.component.spec.ts`. * Add methods to get and update new variables in `frontend/src/app/services/settings.service.ts`. * Add methods to get and update new variables in `backend/src/services/settings.service.ts`. * Add methods to get and update new variables in `backend/src/controllers/settings.controller.ts`. * Create `TargetValues` model in `backend/src/models/target-values.model.ts`. * Create `TargetValuesController` in `backend/src/controllers/target-values.controller.ts`. * Create `TargetValuesService` in `backend/src/services/target-values.service.ts`. * Create routes for `TargetValues` in `backend/src/routes/target-values.routes.ts`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/austenstone/github-value?shareId=XXXX-XXXX-XXXX-XXXX).

github-actions · 2024-11-19T02:13:22Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files

frontend/src/app/main/copilot/predictive-modeling/predictive-modeling.component.ts

…enhance validation

…roller, model, and form for predictive modeling

Add PredictiveModelingComponent to load settings and target data, and save target values. * **frontend/src/app/main/copilot/predictive-modeling/predictive-modeling.component.ts** - Create PredictiveModelingComponent with settings and target forms. - Load settings and target data from PredictiveModelingService. - Add saveTargets method to save target values. * **frontend/src/app/main/copilot/predictive-modeling/predictive-modeling.component.html** - Create HTML template with left column for settings and target values. - Add right column for calculated fields. - Include "Save Targets" button. * **frontend/src/app/main/copilot/predictive-modeling/predictive-modeling.component.scss** - Add styles for predictive-modeling-container, left and right columns, and button. * **frontend/src/app/services/predictive-modeling.service.ts** - Create PredictiveModelingService to handle data fetching and saving. - Implement methods to get settings, targets, and calculated fields, and save targets. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/austenstone/github-value?shareId=XXXX-XXXX-XXXX-XXXX).

…ictive-modeling

backend/src/routes/target-values.routes.ts

frontend/src/app/services/predictive-modeling.service.ts

+  constructor(private http: HttpClient) {}
+
+  getTargets() {
+    return this.http.get<any>(`${this.apiUrl}/targets`);


To fix the problem, we need to replace the any type with a more specific type that accurately represents the data being returned by the HTTP requests. This involves defining TypeScript interfaces or types that match the expected structure of the data. We will need to update the return types of the getTargets, saveTargets, and getCalculatedFields methods accordingly.

Define interfaces for the expected data structures.

Replace the any type with the newly defined interfaces in the HTTP request methods.

frontend/src/app/services/predictive-modeling.service.ts

+    return this.http.get<any>(`${this.apiUrl}/targets`);
+  }
+
+  saveTargets(targets: any) {


To fix the problem, we need to replace the any type with a more specific type. This involves defining an appropriate interface or type for the targets parameter and the return types of the HTTP requests. We will define a Target interface to represent the structure of the targets data and use it in place of any.

frontend/src/app/services/predictive-modeling.service.ts

+  }
+
+  saveTargets(targets: any) {
+    return this.http.post<any>(`${this.apiUrl}/targets`, targets);


To fix the problem, we need to replace the any type with more specific types that accurately describe the data being handled. This involves defining TypeScript interfaces or types that match the structure of the data returned by the API endpoints and used in the methods.

Define interfaces for the data structures returned by the API endpoints and used in the methods.

Replace the any type in the getTargets, saveTargets, and getCalculatedFields methods with the newly defined interfaces.

frontend/src/app/services/predictive-modeling.service.ts

+  }
+
+  getCalculatedFields() {
+    return this.http.get<any>(`${this.apiUrl}/calculated-fields`);


To fix the problem, we need to replace the any type with a more specific type that accurately represents the data being returned by the HTTP requests. This involves defining TypeScript interfaces or types that match the expected structure of the data. We will need to update the return types of the getTargets, saveTargets, and getCalculatedFields methods accordingly.

Define interfaces for the expected data structures.

Replace the any type with the newly defined interfaces in the HTTP request methods.

…lean up imports

austenstone

LGTM 🚀

MattG57 added 2 commits November 18, 2024 21:18

first fix cycle

d7894c2

change cycle 2

3aacb8b

github-advanced-security bot found potential problems Nov 19, 2024

View reviewed changes

MattG57 and others added 17 commits November 18, 2024 21:42

cycle 3

2fd8b35

cycle 4

25514b1

Refactor Predictive Modeling component: streamline form handling and …

7ceb664

…enhance validation

Implement Target Values API and frontend component; add service, cont…

cbfcbf1

…roller, model, and form for predictive modeling

text edit

b3b232d

Merge branch 'main' into MattG57/add-predictive-modeling1

de6ff0d

Merge branch 'main' into ghcw-session-24dd

fc0b7b6

Merge branch 'main' into MattG57/add-predictive-modeling

e9f3860

Merge branch 'main' into ghcw-session-24dd

910815c

Merge branch 'main' into MattG57/add-predictive-modeling1

5a7bada

Remove TargetValues controller, routes, and service files

9db5698

Merge branch 'main' into MattG57/add-predictive-modeling

0ece3b2

Merge branch 'main' into MattG57/add-predictive-modeling

8cba2be

Merge branch 'ghcw-session-24dd' into MattG57/add-predictive-modeling

7b242dd

Merge branch 'main' into MattG57/add-predictive-modeling1

924039f

Merge branch 'MattG57/add-predictive-modeling1' into MattG57/add-pred…

38279f6

…ictive-modeling

github-advanced-security bot found potential problems Nov 21, 2024

View reviewed changes

backend/src/routes/target-values.routes.ts Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Nov 21, 2024

View reviewed changes

austenstone added 2 commits November 21, 2024 13:05

Refactor settings controller and service: remove unused methods and c…

b1d0600

…lean up imports

Refactor settings service: remove unused methods and clean up routes

eab3cae

austenstone approved these changes Nov 21, 2024

View reviewed changes

austenstone merged commit 54d4b8f into main Nov 21, 2024
10 of 11 checks passed

austenstone deleted the MattG57/add-predictive-modeling branch November 21, 2024 18:10

@@ -4,2 +4,14 @@
+            interface Target {
+              id: number;
+              name: string;
+              // Add other properties as needed
+            }
+            interface CalculatedField {
+              id: number;
+              formula: string;
+              // Add other properties as needed
+            }
             @Injectable({
@@ -13,7 +25,7 @@
               getTargets() {
-                return this.http.get<any>(`${this.apiUrl}/targets`);
+                return this.http.get<Target[]>(`${this.apiUrl}/targets`);
               }
-              saveTargets(targets: any) {
-                return this.http.post<any>(`${this.apiUrl}/targets`, targets);
+              saveTargets(targets: Target[]) {
+                return this.http.post<Target[]>(`${this.apiUrl}/targets`, targets);
               }
@@ -21,3 +33,3 @@
               getCalculatedFields() {
-                return this.http.get<any>(`${this.apiUrl}/calculated-fields`);
+                return this.http.get<CalculatedField[]>(`${this.apiUrl}/calculated-fields`);
               }

@@ -4,2 +4,8 @@
+            interface Target {
+              id: number;
+              name: string;
+              // Add other properties as needed
+            }
             @Injectable({
@@ -13,7 +19,7 @@
               getTargets() {
-                return this.http.get<any>(`${this.apiUrl}/targets`);
+                return this.http.get<Target[]>(`${this.apiUrl}/targets`);
               }
-              saveTargets(targets: any) {
-                return this.http.post<any>(`${this.apiUrl}/targets`, targets);
+              saveTargets(targets: Target[]) {
+                return this.http.post<void>(`${this.apiUrl}/targets`, targets);
               }
@@ -21,3 +27,3 @@
               getCalculatedFields() {
-                return this.http.get<any>(`${this.apiUrl}/calculated-fields`);
+                return this.http.get<any[]>(`${this.apiUrl}/calculated-fields`);
               }

@@ -3,2 +3,3 @@
             import { serverUrl } from './server.service';
+            import { Target, CalculatedField } from '../models/predictive-modeling.models';
@@ -13,7 +14,7 @@
               getTargets() {
-                return this.http.get<any>(`${this.apiUrl}/targets`);
+                return this.http.get<Target[]>(`${this.apiUrl}/targets`);
               }
-              saveTargets(targets: any) {
-                return this.http.post<any>(`${this.apiUrl}/targets`, targets);
+              saveTargets(targets: Target[]) {
+                return this.http.post<void>(`${this.apiUrl}/targets`, targets);
               }
@@ -21,4 +22,16 @@
               getCalculatedFields() {
-                return this.http.get<any>(`${this.apiUrl}/calculated-fields`);
+                return this.http.get<CalculatedField[]>(`${this.apiUrl}/calculated-fields`);
               }
             }
+            export interface Target {
+              id: number;
+              name: string;
+              // Add other properties as needed
+            }
+            export interface CalculatedField {
+              id: number;
+              formula: string;
+              // Add other properties as needed
+            }

@@ -3,2 +3,3 @@
             import { serverUrl } from './server.service';
+            import { Target, CalculatedField } from './types';
@@ -13,7 +14,7 @@
               getTargets() {
-                return this.http.get<any>(`${this.apiUrl}/targets`);
+                return this.http.get<Target[]>(`${this.apiUrl}/targets`);
               }
-              saveTargets(targets: any) {
-                return this.http.post<any>(`${this.apiUrl}/targets`, targets);
+              saveTargets(targets: Target[]) {
+                return this.http.post<void>(`${this.apiUrl}/targets`, targets);
               }
@@ -21,4 +22,16 @@
               getCalculatedFields() {
-                return this.http.get<any>(`${this.apiUrl}/calculated-fields`);
+                return this.http.get<CalculatedField[]>(`${this.apiUrl}/calculated-fields`);
               }
             }
+            export interface Target {
+              id: number;
+              name: string;
+              // Add other properties as needed
+            }
+            export interface CalculatedField {
+              id: number;
+              formula: string;
+              // Add other properties as needed
+            }

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Predictive Modeling page and update settings #61

Add Predictive Modeling page and update settings #61

MattG57 commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 19, 2024 •

edited

Loading

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

austenstone left a comment

Add Predictive Modeling page and update settings #61

Add Predictive Modeling page and update settings #61

Conversation

MattG57 commented Nov 19, 2024 • edited Loading

github-actions bot commented Nov 19, 2024 • edited Loading

Dependency Review

OpenSSF Scorecard

Scanned Files

austenstone left a comment

Choose a reason for hiding this comment

MattG57 commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 19, 2024 •

edited

Loading