Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename magic-create to magic-config #365

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Rename magic-create to magic-config #365

merged 2 commits into from
Feb 8, 2024

Conversation

bigadsoleiman
Copy link
Collaborator

@bigadsoleiman bigadsoleiman commented Feb 8, 2024

Issue #, if available: #192

Description of changes:

  • Renaming CLI from create to config. This should help avoid confusion allowing to run the CLI an arbitrary amount of times to update the config and not just one-off at creation phase.
  • Updated docs

Manual testing:

  • Redeployed from scratch successfully + several config updates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bigadsoleiman bigadsoleiman marked this pull request as ready for review February 8, 2024 11:40
@bigadsoleiman bigadsoleiman merged commit 3837de7 into main Feb 8, 2024
1 check passed
@bigadsoleiman bigadsoleiman deleted the rename_create branch June 10, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant