Bump k8s.io/apimachinery from 0.30.1 to 0.31.1 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.30.1 to 0.31.1. - [Commits](kubernetes/apimachinery@v0.30.1...v0.31.1) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
orsenthil
reviewed
Sep 25, 2024
| @@ -53,17 +54,17 @@ func (h *enqueueRequestForNamespaceEvent) Update(ctx context.Context, event even | |||
| h.enqueueReferredPolicies(ctx, q, nsNew, nsOld) | |||
| } | |||
|
|
|||
| func (h *enqueueRequestForNamespaceEvent) Delete(ctx context.Context, event event.DeleteEvent, q workqueue.RateLimitingInterface) { | |||
| func (h *enqueueRequestForNamespaceEvent) Delete(ctx context.Context, event event.DeleteEvent, q workqueue.TypedRateLimitingInterface[reconcile.Request]) { | |||
There was a problem hiding this comment.
Did the dependency update bring this API change?
|
@yash97 - Did the dependency update bring the API change? Why do we have to change the event handler interfaces. |
|
@orsenthil yes. Updating api machinery to 0.31.1 changes function signature of function This function signature is implemented correctly in version of 0.19.0 of controller-runtime. Now Controller-runtime 0.19.0 version introduces generic typedReconciler which changes interface signature. Release Notes:- https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.19.0. |
dependabot
bot
deleted the
dependabot/go_modules/k8s.io/apimachinery-0.31.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps k8s.io/apimachinery from 0.30.1 to 0.31.1.
Commits
a8f449eFalls back to SPDY for gorilla/websocket https proxy error62791ecMerge pull request #125571 from liggitt/filter-auth-02-sarcc2ba35add field and label selectors to authorization attributesce76a8fgenerate35052c5add subjectaccessreview field and label selectorsab06869Merge pull request #126105 from benluddy/cbor-framer429f4e4Implement runtime.Framer for CBOR Sequences.d7e1c53Merge pull request #126018 from aroradaman/bump-k8s-utils07cb122Merge pull request #125748 from benluddy/cbor-custom-marshalersdd17456bump k8s.io/utilsYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Adding default marker for Protocol to be TCP.
controller gen release notes:- https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.16.0