Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PE to support a new ns scoped pods field and status conditions #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

haouc
Copy link
Contributor

@haouc haouc commented Jan 25, 2024

What type of PR is this?

feature
Which issue does this PR fix:
This PR adds a new Spec field to support NS scoped pods and Conditions into Status to support PE objects' states tracking.

What does this PR do / Why do we need it:
We need them to support NA features and expose critical state changes of PE objects to customers.

If an issue # is not available please add steps to reproduce and the controller logs:

Testing done on this change:

new Spec field

"allPodsInNamespace": true,

conditions

Status:
  Conditions:
    Last Transition Time:  2024-01-26T00:48:19Z                      <--- condition is set/updated when the PE is binpacked
    Message:               binpacked network policy endpoint slices on Ingress - false, Egress - false, PodSelector - true with RV 9290751
    Reason:                PEBinPacked
    Status:                True
    Type:                  PackedPolicyEndpoint
    Last Transition Time:  2024-01-26T00:33:44Z                      <--- condition is set when the PE is created
    Message:               object is awaiting reconciliation
    Reason:                AwaitingReconciliation
    Status:                Unknown
    Type:                  Ready

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
This shouldn't support downgraded PE CRD. Upgrading is supported and worked in test clusters.

Does this PR introduce any user-facing change?:

Yes. PE objects' states are exposed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haouc haouc requested a review from a team as a code owner January 25, 2024 02:54
@haouc haouc force-pushed the update-pe branch 2 times, most recently from d24d234 to 06e409c Compare January 26, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant