[V2] Add Python 3.12 Support #8897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In reply to the only failing check, it is due to a failed assertion on the version of urllib3. For some reason, the the regenerated portable-exe-win-lock.txt file expects 1.26.19, but our lockfile has 1.26.20 pinned. Both satisfy our pyproject.toml requirement of |
hssyoo
requested changes
Sep 10, 2024
requirements-build.txt
Outdated
| @@ -1,4 +1,5 @@ | |||
| # Requirements we need to run our build jobs for the installers. | |||
| # We create the separation for cases where we're doing installation | |||
| # from a local dependency directory instead of requirements.txt. | |||
| PyInstaller==5.12.0 | |||
| PyInstaller==5.13.2 | |||
| pip==24.0 | |||
Comment on lines
276
to
280
| with warnings.catch_warnings(record=True) as caught_warnings: | ||
| response = method(**kwargs) | ||
| err_msg = f"Warnings were emitted during smoke test: {caught_warnings}" | ||
| assert len(caught_warnings) == 0, err_msg | ||
| assert 'Errors' not in response |
There was a problem hiding this comment.
Why do we need to do this? The PR description doesn't go into what this is fixing. It just looks like we're getting less coverage. It looks like botocore never removed the warnings assertion here. We should avoid drifting if it's not necessary.
aemous
force-pushed
the
v2_python312
branch
from
de25dce to
40e8220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds changes needed to support Python version 3.12. A highlight of the changes are:
pyproject.toml.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.