Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate security credentials obtained from Instance Metadata Service #3203

Open
wants to merge 1 commit into
base: main-staging
Choose a base branch
from

Conversation

opottone
Copy link

Description

Getting security credentials from Instance Metadata Service fails when an EC2 instance does not have permissions to assume a role. When that happens, we get a very unhelpful error message Value cannot be null. (Parameter 'awsAccessKeyId') Do response validation so that we get better exception message.

See also aws/aws-cli#2060

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

Getting security credentials from Instance Metadata Service fails
when an EC2 instance does not have permissions to assume a role.
When that happens, we get a very unhelpful error message
"Value cannot be null. (Parameter 'awsAccessKeyId')"
Do response validation so that we get better exception message.

See also aws/aws-cli#2060
@dscpinheiro dscpinheiro changed the base branch from main to main-staging February 28, 2024 11:57
@bhoradc bhoradc requested a review from normj March 1, 2024 17:29
@ashishdhingra
Copy link
Contributor

The change needs to be tested in all compute environments (like EC2, ECS, EKS, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants