Fix #3173 trim warning for Constant Class #3466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ConstantClass's Intern method is not trim compatible because we cannot guarantee that the object returned by
GetType()
will have its public fields untrimmed, whichLoadFields
expects. Since we cannot directly annotateSystem.GetType()
, we have to apply theDynamicallyAccessedMembers
attribute toConstantClass
itself to guarantee thatLoadFields
will receive an object with its public fields untrimmed.Motivation and Context
Fixes #3173.
Testing
DRY_RUN successful
I created a simple console app with trimming enable and then ran
dotnet publish --sc -f net8.0
and the warning went away.Screenshots (if appropriate)
Types of changes
Checklist
License