nix: Skip the sslyze test on arm #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougch
commented
Jun 14, 2023
lrstewart
reviewed
Jun 14, 2023
toidiu
approved these changes
Jun 15, 2023
goatgoose
reviewed
Jun 23, 2023
| ps.typing-extensions | ||
| ps.setuptools-rust | ||
| ps.cryptography | ||
| ] ++ (if pkgs.stdenv.hostPlatform.system == "x86_64-linux" then [ |
There was a problem hiding this comment.
The sslyze test seems to run for every platform except aarch64, but the sslyze dependency is installed only on linux x86_64. Is there any concern about running the integ tests on a platform other than aarch64 or linux x86-64? Like, if you were to try and run the integ tests on mac, would it attempt to run sslyze but fail because the dependency isn't installed?
There was a problem hiding this comment.
Just being cautious here, the other possible platform that might get these packages is x86_64-darwin, which we'll add when doing the darwin nix work. If the dependency can't be installed, the devShell won't even start.
goatgoose
approved these changes
Jun 26, 2023
tinzh
pushed a commit
to tinzh/s2n-tls
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
n/a
Description of changes:
Skip running the sslyze integration test under nix and aarch64-linux. This should be the last nix related PR before we can start running integrations tests on aarch64-linux.
Call-outs:
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? local and CI
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.