Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to enable the default registry #504

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amancevice
Copy link

Issue #, if available:

N/A

Description of changes:

While not officially supported, it is possible to alias an ECR registry with DNS (eg ecr.example.io).

This change adds support for the AWS_ECR_USE_DEFAULT_REGISTRY environment variable which, when set to a non-empty value, will force this tool to use the default registry when authenticating.

I am not married to this implementation; if the maintainers have a better idea for allowing users to use this tool with non-AWS-style registry names I'm happy to try to implement!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amancevice amancevice requested review from a team as code owners March 12, 2023 22:20
@amancevice amancevice force-pushed the allow-default-registry branch from a682acb to 7fabfc3 Compare March 25, 2024 13:32
While not "officially" supported, it is possible to alias an ECR registry with DNS (eg ecr.example.io).

This change adds support for the AWS_ECR_USE_DEFAULT_REGISTRY environment variable which,
when set to a non-empty value, will force this tool to use the default registry when authenticating.
@amancevice amancevice force-pushed the allow-default-registry branch from 7fabfc3 to 378cc07 Compare September 18, 2024 02:00
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant