try removing test that Secitem doesn't support

awslabs · Oct 25, 2024 · cff20a6 · cff20a6
1 parent 8ffbc9e
commit cff20a6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -93,7 +93,6 @@ add_test_case(wrong_thread_read_write_fails)
 add_test_case(incoming_duplicate_tcp_bind_errors)
 endif()
 
-
 if(WIN32)
     add_test_case(local_socket_pipe_connected_race)
 endif()
@@ -214,7 +213,10 @@ if(NOT BYO_CRYPTO)
     if(NOT(WIN32 AND NOT CMAKE_SYSTEM_VERSION MATCHES "10\.0\.1.*"))
         # Skip TLS 1.0 and TLS 1.1 test for windows later than windows server 2022, as they droped old TLS
         add_net_test_case(tls_client_channel_negotiation_error_legacy_crypto_tls10)
+        if(NOT AWS_USE_SECITEM)
+        # SecItem does not allow use of depricated TLS versions
         add_net_test_case(tls_client_channel_negotiation_override_legacy_crypto_tls10)
+        endif()
         add_net_test_case(tls_client_channel_negotiation_error_override_legacy_crypto_tls11)
         add_net_test_case(tls_client_channel_negotiation_success_legacy_crypto_tls11)
     endif()

diff --git a/tests/tls_handler_test.c b/tests/tls_handler_test.c
@@ -1523,10 +1523,6 @@ static int s_tls_client_channel_negotiation_override_legacy_crypto_tls10_fn(
     struct aws_allocator *allocator,
     void *ctx) {
     (void)ctx;
-#    if defined(AWS_USE_SEITEM)
-    // Apple Network Framework does not allow use of deprecated TLS versions.
-    return AWS_OP_SKIP;
-#    endif
     return s_verify_good_host(allocator, s_legacy_crypto_tls10_host_name, 1010, &s_lower_tls_version);
 }