cleanup and test fix for windows

awslabs · Nov 5, 2024 · e66a9a6 · e66a9a6
1 parent 1efece0
commit e66a9a6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/source/darwin/nw_socket.c b/source/darwin/nw_socket.c
@@ -437,12 +437,6 @@ static void s_setup_tls_options(
               aws_raise_error(error_code);
               CFRelease(error);
           }
-          // DEBUG WIP trigger the on_negotiation_result func w/error here?
-          // We may be able to remove on_tls_negotiation_result_fn from nw_socket
-          // if (nw_socket->on_tls_negotiation_result_fn) {
-          // nw_socket->on_tls_negotiation_result_fn(
-          //     NULL, NULL, error_code, nw_socket->on_tls_negotiation_result_user_data);
-          // }
           complete(verification_successful);
         },
         dispatch_loop->dispatch_queue);

diff --git a/tests/socket_test.c b/tests/socket_test.c
@@ -2064,7 +2064,7 @@ static int s_local_socket_pipe_connected_race(struct aws_allocator *allocator, v
     struct aws_socket listener;
     ASSERT_SUCCESS(aws_socket_init(&listener, allocator, &options));
 
-    ASSERT_SUCCESS(aws_socket_bind(&listener, &endpoint));
+    ASSERT_SUCCESS(aws_socket_bind(&listener, &endpoint, NULL, NULL));
 
     ASSERT_SUCCESS(aws_socket_listen(&listener, 1024));