Cache the Error Before Any Side Effects #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
changed the title
| on_error: | ||
| on_error:; | ||
| /* cache the error code to prevent any potential side effects */ | ||
| int cached_error_code = aws_last_error(); | ||
|
|
||
| aws_mem_release(alloc, usable_cpus); | ||
| s_aws_event_loop_group_shutdown_sync(el_group); |
There was a problem hiding this comment.
is one of those throwing some new error because it cant clean up correctly? should we fix that as well?
There was a problem hiding this comment.
There's code in here that loops through a priority list until it raises the AWS_ERROR_PRIORITY_QUEUE_EMPTY, indicating it's empty.
So it's not an error-as-fail, it's an error-code-as-flow-control
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
==========================================
- Coverage 80.09% 80.06% -0.03%
==========================================
Files 28 28
Lines 5943 5945 +2
==========================================
Hits 4760 4760
- Misses 1183 1185 +2 ☔ View full report in Codecov by Sentry. |
graebm
approved these changes
Jan 24, 2024
| @@ -165,12 +165,16 @@ static struct aws_event_loop_group *s_event_loop_group_new( | |||
|
|
|||
| return el_group; | |||
|
|
|||
| on_error: | |||
| on_error:; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
AWS_ERROR_PRIORITY_QUEUE_EMPTY, when we failed inaws_event_loop_runwhile doingpthread_create.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.